Uploaded image for project: 'Calcite'
  1. Calcite
  2. CALCITE-5647

RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq)

    XMLWordPrintableJSON

Details

    Description

      A few locations in Calcite call rel.estimateRowCount(mq) when they should instead call mq.getRowCount(red).

      We detected this because we implemented row count estimation entirely within an alternative handle instead of RelMdRowCount, and then override estimateRowCount to ensure the custom handler is user, by throwing an unreachable code exception.

      A few places in Calcite trigger these unreachable exceptions because they do not use mq.getRowCount.

      The most easily triggered on is in RelMdPopulationSize for the Values parameter.

      Attachments

        Issue Links

          Activity

            People

              adamkennedy77 Adam Kennedy
              adamkennedy77 Adam Kennedy
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Time Spent - 20m Remaining Estimate - 40m
                  40m
                  Logged:
                  Time Spent - 20m Remaining Estimate - 40m
                  20m